Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Import EdgeX v2.0.0 #326

Closed
wants to merge 5 commits into from
Closed

[DO NOT MERGE] Import EdgeX v2.0.0 #326

wants to merge 5 commits into from

Conversation

tiokim
Copy link
Contributor

@tiokim tiokim commented Jul 5, 2021

Description

This is a temporary branch for testing edgex v2.0.0 against DataStorage.

WIP #324

Issue

EdgeX uses 0mq which is a shared library and makes cross-compilation difficult.

Type of change

  • Code cleanup/refactoring
  • This change requires a documentation update

How Has This Been Tested?

See #324 (comment)


Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tdrozdovsky
Copy link
Contributor

Thank you! I think the Go version should also be changed here:

docs/platforms/orange_pi3/orange_pi3.md:72:- go compiler (install a version not lower than 1.12.5)
docs/platforms/raspberry_pi3/raspberry_pi3.md:70:- go compiler (install a version not lower than 1.12.5, recommended v1.14.x)
docs/platforms/x86_64_linux/x86_64_linux.md:40:- go compiler

It is also possible to exclude the build possibility of edge-orchestration directly on boards (orange_pi3 and raspberry_pi3 ) Since it may be difficult to support Go newest version. What do you think about it?

@@ -1,4 +1,4 @@
# * Copyright 2020 Intel Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you need to change the year of issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pasted the orignal code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Great!

@tiokim
Copy link
Contributor Author

tiokim commented Jul 8, 2021

Thank you! I think the Go version should also be changed here:

docs/platforms/orange_pi3/orange_pi3.md:72:- go compiler (install a version not lower than 1.12.5)
docs/platforms/raspberry_pi3/raspberry_pi3.md:70:- go compiler (install a version not lower than 1.12.5, recommended v1.14.x)
docs/platforms/x86_64_linux/x86_64_linux.md:40:- go compiler

Thanks for the information!

It is also possible to exclude the build possibility of edge-orchestration directly on boards (orange_pi3 and raspberry_pi3 ) Since it may be difficult to support Go newest version. What do you think about it?

We build the edge-orchestration in terms of OS architecture rather than development boards, and I think we don't need to remove it at this time because golang supports different OS architectures. I'd like to talk about this issue when we encounter this problem.

@tiokim
Copy link
Contributor Author

tiokim commented Dec 3, 2021

EdgeX v2.1(Jakarta) has been released. We will think of what version of edgex should be taken.

@tiokim tiokim closed this Dec 3, 2021
@tiokim tiokim deleted the ds_ireland branch February 16, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants