Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support conversion in fastjson #1962

Merged
merged 16 commits into from
Jun 6, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jun 1, 2023

No description provided.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 62.07% and project coverage change: +0.03 🎉

Comparison is base (c0ba4d5) 60.07% compared to head (74b8b4d) 60.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   60.07%   60.10%   +0.03%     
==========================================
  Files         274      274              
  Lines       31223    31314      +91     
==========================================
+ Hits        18755    18819      +64     
- Misses      10586    10614      +28     
+ Partials     1882     1881       -1     
Impacted Files Coverage Δ
internal/converter/json/converter.go 59.12% <62.07%> (-0.80%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying June 2, 2023 04:58
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a strictValidation property when creating a stream. Maybe we need to handle both true/false for that property in another PR.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying June 5, 2023 06:30
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case "string", "bytea", why the code are the same. There are actually different types. bytea is expected to be []byte.

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Copy link
Collaborator Author

Yisaer commented Jun 6, 2023

case "string", "bytea", why the code are the same. There are actually different types. bytea is expected to be []byte.

updated.

@Yisaer Yisaer requested a review from ngjaying June 6, 2023 04:02
internal/converter/json/converter.go Outdated Show resolved Hide resolved
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying June 6, 2023 07:10
Signed-off-by: yisaer <disxiaofei@163.com>
@ngjaying ngjaying merged commit 31cd951 into lf-edge:master Jun 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants