Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support single quote string literal #1974

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

Rui-Gan
Copy link
Collaborator

@Rui-Gan Rui-Gan commented Jun 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12 ⚠️

Comparison is base (dfa9b5e) 60.21% compared to head (a37115e) 60.09%.

❗ Current head a37115e differs from pull request most recent head d598ddd. Consider uploading reports for the commit d598ddd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1974      +/-   ##
==========================================
- Coverage   60.21%   60.09%   -0.12%     
==========================================
  Files         274      274              
  Lines       31329    31231      -98     
==========================================
- Hits        18862    18767      -95     
+ Misses      10594    10583      -11     
- Partials     1873     1881       +8     
Impacted Files Coverage Δ
pkg/ast/token.go 92.68% <ø> (ø)
internal/xsql/lexical.go 87.09% <100.00%> (+0.40%) ⬆️
internal/xsql/parser.go 75.17% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rui-Gan Rui-Gan marked this pull request as ready for review June 6, 2023 09:31
@ngjaying
Copy link
Collaborator

ngjaying commented Jun 7, 2023

What's the behavior of 'abc"' or "abc'cba" or "abc'

@Rui-Gan Rui-Gan marked this pull request as draft June 7, 2023 03:06
Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
@Rui-Gan
Copy link
Collaborator Author

Rui-Gan commented Jun 7, 2023

What's the behavior of 'abc"' or "abc'cba" or "abc'

'abc"'->abc"
"abc'cba" ->abc'cba
"abc'->invalid syntax

@Rui-Gan Rui-Gan marked this pull request as ready for review June 7, 2023 07:54
@ngjaying ngjaying merged commit 6a30abe into lf-edge:master Jun 7, 2023
8 checks passed
ngjaying pushed a commit that referenced this pull request Jun 9, 2023
* support singlequote

Signed-off-by: Rui-Gan <1171530954@qq.com>

* fix singlequote

Signed-off-by: Rui-Gan <1171530954@qq.com>

---------

Signed-off-by: Rui-Gan <1171530954@qq.com>
@Rui-Gan Rui-Gan deleted the quote branch July 5, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants