fix: support gc logs when started #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yisaer <disxiaofei@163.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
+ Coverage 60.56% 60.57% +0.02%
==========================================
Files 279 279
Lines 32034 32085 +51
==========================================
+ Hits 19399 19435 +36
- Misses 10739 10751 +12
- Partials 1896 1899 +3
☔ View full report in Codecov by Sentry. |
|
Would you like to add some tests for errors to pass codecov check? |
superrxan
approved these changes
Jun 30, 2023
ngjaying
pushed a commit
to ngjaying/kuiper
that referenced
this pull request
Jul 7, 2023
* support gc logs Signed-off-by: yisaer <disxiaofei@163.com> * add test Signed-off-by: yisaer <disxiaofei@163.com> --------- Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying
pushed a commit
that referenced
this pull request
Jul 7, 2023
* support gc logs Signed-off-by: yisaer <disxiaofei@163.com> * add test Signed-off-by: yisaer <disxiaofei@163.com> --------- Signed-off-by: yisaer <disxiaofei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.