Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let window Left-closed right-open #2053

Merged
merged 6 commits into from
Jul 4, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 3, 2023

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 96.67% and project coverage change: +0.15 🎉

Comparison is base (9e8ce6b) 60.61% compared to head (79d79be) 60.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   60.61%   60.76%   +0.15%     
==========================================
  Files         279      279              
  Lines       32173    32188      +15     
==========================================
+ Hits        19501    19558      +57     
+ Misses      10765    10729      -36     
+ Partials     1907     1901       -6     
Impacted Files Coverage Δ
internal/topo/topotest/mocknode/mock_data.go 45.45% <ø> (ø)
internal/topo/node/window_op.go 78.37% <96.43%> (+0.98%) ⬆️
internal/topo/topotest/mock_topo.go 77.29% <100.00%> (+0.13%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review July 4, 2023 04:44
@Yisaer Yisaer requested a review from ngjaying July 4, 2023 05:42
@ngjaying ngjaying merged commit 60764ef into lf-edge:master Jul 4, 2023
10 checks passed
@Yisaer Yisaer deleted the change_window_2 branch July 4, 2023 06:19
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jul 7, 2023
* add code

Signed-off-by: yisaer <disxiaofei@163.com>

* add test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix lint

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

---------

Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jul 7, 2023
* add code

Signed-off-by: yisaer <disxiaofei@163.com>

* add test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix lint

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

---------

Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jul 7, 2023
* add code

Signed-off-by: yisaer <disxiaofei@163.com>

* add test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix lint

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

---------

Signed-off-by: yisaer <disxiaofei@163.com>
ngjaying pushed a commit that referenced this pull request Jul 7, 2023
* add code

Signed-off-by: yisaer <disxiaofei@163.com>

* add test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix lint

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

* fix test

Signed-off-by: yisaer <disxiaofei@163.com>

---------

Signed-off-by: yisaer <disxiaofei@163.com>
@ngjaying
Copy link
Collaborator

ngjaying commented Jul 7, 2023

Closes #2044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants