-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add timezone support #2064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the default timezone value? Local? Need to add that to the default kuiper.yaml explicitly. Also, need to add the doc.
The default timezone is UTC. This will prevent behavior changes due to different system’s timezone settings. I will open another PR for docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we need to explicitly define that in the conf file. I prefer doc change comes with the PR which is helpful for reviewer to understand the code.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2064 +/- ##
==========================================
- Coverage 60.62% 60.61% -0.02%
==========================================
Files 279 279
Lines 32187 32267 +80
==========================================
+ Hits 19513 19556 +43
- Misses 10764 10792 +28
- Partials 1910 1919 +9
☔ View full report in Codecov by Sentry. |
Signed-off-by: xjasonlyu <xjasonlyu@gmail.com>
Signed-off-by: xjasonlyu <xjasonlyu@gmail.com>
Signed-off-by: xjasonlyu <xjasonlyu@gmail.com>
No description provided.