Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extended wildcard follow up works #2085

Merged
merged 6 commits into from
Jul 13, 2023
Merged

Conversation

Rui-Gan
Copy link
Collaborator

@Rui-Gan Rui-Gan commented Jul 10, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (8767e03) 60.89% compared to head (d187dcd) 60.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
+ Coverage   60.89%   60.95%   +0.06%     
==========================================
  Files         280      280              
  Lines       32615    32636      +21     
==========================================
+ Hits        19859    19891      +32     
+ Misses      10836    10829       -7     
+ Partials     1920     1916       -4     
Impacted Files Coverage Δ
internal/topo/planner/projectPlan.go 100.00% <ø> (+12.90%) ⬆️
internal/xsql/valuer.go 58.93% <ø> (-0.04%) ⬇️
internal/topo/planner/dataSourcePlan.go 83.96% <100.00%> (+1.81%) ⬆️
pkg/ast/visitor.go 94.06% <100.00%> (+0.24%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Rui-Gan Rui-Gan marked this pull request as ready for review July 11, 2023 10:02
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use * except in where clause? It is not tested.

Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
@Rui-Gan
Copy link
Collaborator Author

Rui-Gan commented Jul 12, 2023

Is it possible to use * except in where clause? It is not tested.

I add UT using * except and * replace in the Having clause, but I currently cannot think of an example where * except can be used in the Where clause.

@Rui-Gan Rui-Gan marked this pull request as draft July 12, 2023 07:55
Signed-off-by: Rui-Gan <1171530954@qq.com>
@Rui-Gan Rui-Gan marked this pull request as ready for review July 12, 2023 10:31
@ngjaying ngjaying merged commit e135322 into lf-edge:master Jul 13, 2023
10 checks passed
@Rui-Gan Rui-Gan deleted the prune branch July 26, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants