Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit process after an error occurs #2098

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

ke4nec
Copy link
Contributor

@ke4nec ke4nec commented Jul 17, 2023

exit process after an error occurs like bind failed "bind: address already in use"

Signed-off-by: ke4nec ke4nec@qq.com

exit process after an error occurs like bind failed "bind: address already in use"

Signed-off-by: ke4nec <ke4nec@qq.com>
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (2c248ca) 61.07% compared to head (bf2ddd3) 60.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2098      +/-   ##
==========================================
- Coverage   61.07%   60.91%   -0.16%     
==========================================
  Files         280      280              
  Lines       32645    32645              
==========================================
- Hits        19935    19883      -52     
- Misses      10799    10846      +47     
- Partials     1911     1916       +5     
Impacted Files Coverage Δ
internal/server/server.go 6.63% <0.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We suppose use can still use CLI to manage withour REST. After discussions, we think REST API is important enough to fail the starting. Thanks.

@ngjaying ngjaying merged commit 89e6aa5 into lf-edge:master Jul 17, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants