Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support resend destination #2119

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

ngjaying
Copy link
Collaborator

  • Add http, rest sink support
  • Add docs

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.02 ⚠️

Comparison is base (7af9b26) 61.38% compared to head (0811ab0) 61.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2119      +/-   ##
==========================================
- Coverage   61.38%   61.36%   -0.02%     
==========================================
  Files         281      281              
  Lines       32931    32942      +11     
==========================================
  Hits        20214    20214              
- Misses      10800    10805       +5     
- Partials     1917     1923       +6     
Impacted Files Coverage Δ
internal/io/http/client.go 81.43% <ø> (ø)
internal/io/memory/sink.go 45.83% <66.67%> (+0.28%) ⬆️
internal/io/http/rest_sink.go 57.78% <72.73%> (-1.05%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

- Add http, rest sink support
- Add docs

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying ngjaying requested a review from Yisaer July 21, 2023 00:09
@ngjaying ngjaying marked this pull request as ready for review July 21, 2023 00:09
@ngjaying ngjaying merged commit e9c9dfd into lf-edge:master Jul 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants