Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support accmulative agg funcs #2125

Merged
merged 11 commits into from
Jul 28, 2023
Merged

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 25, 2023

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 70.13% and project coverage change: +0.19% 🎉

Comparison is base (39d3a3c) 61.46% compared to head (c568896) 61.66%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
+ Coverage   61.46%   61.66%   +0.19%     
==========================================
  Files         281      282       +1     
  Lines       33074    33389     +315     
==========================================
+ Hits        20328    20586     +258     
- Misses      10827    10866      +39     
- Partials     1919     1937      +18     
Files Changed Coverage Δ
internal/topo/planner/planner.go 78.67% <ø> (ø)
internal/binder/function/funcs_analytic.go 68.35% <70.00%> (+2.04%) ⬆️
internal/binder/function/function.go 84.38% <100.00%> (+0.25%) ⬆️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review July 25, 2023 08:57
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support OVER WHEN/PARTITION BY for these functions?

internal/binder/function/funcs_agg.go Outdated Show resolved Hide resolved
Signed-off-by: yisaer <disxiaofei@163.com>
internal/binder/function/funcs_agg.go Outdated Show resolved Hide resolved
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer changed the title feat: support global agg funcs feat: support accmulative agg funcs Jul 26, 2023
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying July 26, 2023 08:11
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need docs

Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying July 28, 2023 08:48
Signed-off-by: yisaer <disxiaofei@163.com>
@ngjaying ngjaying merged commit 98df74a into lf-edge:master Jul 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants