Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add object_concat function #2149

Merged
merged 3 commits into from
Aug 4, 2023
Merged

feat: add object_concat function #2149

merged 3 commits into from
Aug 4, 2023

Conversation

Rui-Gan
Copy link
Collaborator

@Rui-Gan Rui-Gan commented Aug 3, 2023

No description provided.

Signed-off-by: Rui-Gan <1171530954@qq.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: +0.08% 🎉

Comparison is base (3a72679) 61.65% compared to head (b1b9e90) 61.73%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
+ Coverage   61.65%   61.73%   +0.08%     
==========================================
  Files         282      285       +3     
  Lines       33475    33595     +120     
==========================================
+ Hits        20636    20738     +102     
- Misses      10886    10903      +17     
- Partials     1953     1954       +1     
Files Changed Coverage Δ
internal/binder/function/funcs_obj.go 85.98% <81.25%> (-0.83%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rui-Gan Rui-Gan marked this pull request as ready for review August 4, 2023 01:29
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the doc

@Rui-Gan Rui-Gan marked this pull request as draft August 4, 2023 05:54
Signed-off-by: Rui-Gan <1171530954@qq.com>
Signed-off-by: Rui-Gan <1171530954@qq.com>
@Rui-Gan Rui-Gan marked this pull request as ready for review August 4, 2023 09:33
@ngjaying ngjaying merged commit f5aff7a into lf-edge:master Aug 4, 2023
12 checks passed
@Rui-Gan Rui-Gan deleted the object branch August 7, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants