Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(restapi): support validate rule #2153

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

Rui-Gan
Copy link
Collaborator

@Rui-Gan Rui-Gan commented Aug 4, 2023

Closes #2120

Signed-off-by: Rui-Gan <1171530954@qq.com>
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 77.27% and project coverage change: +0.06% 🎉

Comparison is base (3a72679) 61.65% compared to head (4b085b3) 61.70%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2153      +/-   ##
==========================================
+ Coverage   61.65%   61.70%   +0.06%     
==========================================
  Files         282      285       +3     
  Lines       33475    33583     +108     
==========================================
+ Hits        20636    20722      +86     
- Misses      10886    10904      +18     
- Partials     1953     1957       +4     
Files Changed Coverage Δ
internal/server/rest.go 49.28% <66.67%> (+0.27%) ⬆️
internal/server/rule_manager.go 58.99% <100.00%> (+1.37%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rui-Gan Rui-Gan marked this pull request as ready for review August 4, 2023 07:51
@ngjaying ngjaying merged commit c72afec into lf-edge:master Aug 4, 2023
16 checks passed
@Rui-Gan Rui-Gan deleted the api branch August 7, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API/CLI to validate rules
2 participants