Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse time should consider loc #2169

Merged
merged 8 commits into from
Aug 11, 2023
Merged

fix: parse time should consider loc #2169

merged 8 commits into from
Aug 11, 2023

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Aug 10, 2023

No description provided.

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer marked this pull request as ready for review August 11, 2023 03:17
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (c4ced28) 62.01% compared to head (95ae5d7) 62.10%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
+ Coverage   62.01%   62.10%   +0.09%     
==========================================
  Files         287      288       +1     
  Lines       33766    34141     +375     
==========================================
+ Hits        20937    21201     +264     
- Misses      10881    10963      +82     
- Partials     1948     1977      +29     
Files Changed Coverage Δ
internal/topo/rule/ruleState.go 73.20% <100.00%> (ø)
pkg/schedule/schedule.go 94.34% <100.00%> (+0.22%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yisaer <disxiaofei@163.com>
Copy link
Collaborator

@superrxan superrxan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. add rulePatrolInterval: "10s" in etc/kuiper.yaml file

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
pkg/schedule/schedule.go Outdated Show resolved Hide resolved
Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@ngjaying ngjaying merged commit e582ab2 into lf-edge:master Aug 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants