Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): hang when cache priority set #2185

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

ngjaying
Copy link
Collaborator

No description provided.

Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 60.53% and project coverage change: +0.43% 🎉

Comparison is base (44024ac) 62.17% compared to head (00f3cab) 62.60%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2185      +/-   ##
==========================================
+ Coverage   62.17%   62.60%   +0.43%     
==========================================
  Files         288      288              
  Lines       34141    34477     +336     
==========================================
+ Hits        21227    21584     +357     
+ Misses      10935    10896      -39     
- Partials     1979     1997      +18     
Files Changed Coverage Δ
internal/topo/node/sink_node.go 79.71% <40.00%> (+0.69%) ⬆️
internal/binder/function/funcs_array.go 72.83% <67.86%> (-0.29%) ⬇️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying marked this pull request as ready for review August 14, 2023 12:26
@ngjaying ngjaying requested a review from Yisaer August 14, 2023 12:26
@ngjaying ngjaying force-pushed the bugfix branch 2 times, most recently from f3e70a1 to 00f3cab Compare August 15, 2023 08:52
@ngjaying ngjaying merged commit 565e145 into lf-edge:master Aug 16, 2023
16 of 17 checks passed
LenaLenaPan pushed a commit that referenced this pull request Aug 30, 2023
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: LenaLenaPan <hilena.pan@gmail.com>
LenaLenaPan pushed a commit that referenced this pull request Aug 30, 2023
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
Signed-off-by: LenaLenaPan <hilena.pan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants