Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the bad variable reference #2984

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

zhang943
Copy link
Contributor

@zhang943 zhang943 commented Jul 4, 2024

fix #2981

Signed-off-by: ZhangZhe <zhangzhe.z@bytedance.com>
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.31%. Comparing base (4abeb38) to head (12b6ad0).

Files Patch % Lines
internal/server/meta_init.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
+ Coverage   65.30%   65.31%   +0.01%     
==========================================
  Files         354      354              
  Lines       34818    34818              
==========================================
+ Hits        22735    22739       +4     
+ Misses       9836     9835       -1     
+ Partials     2247     2244       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying requested a review from Yisaer July 4, 2024 08:30
Copy link
Collaborator

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please unify all the error as err, remove the err1

@ngjaying
Copy link
Collaborator

ngjaying commented Jul 5, 2024

@zhang943 Please check the comment. What do you think? Thanks.

@ngjaying ngjaying merged commit c956d7e into lf-edge:master Jul 11, 2024
56 of 57 checks passed
ngjaying pushed a commit to ngjaying/kuiper that referenced this pull request Jul 18, 2024
Signed-off-by: ZhangZhe <zhangzhe.z@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad variable reference causes a NPE
3 participants