Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinks add redis plugin #895

Merged
merged 2 commits into from Aug 11, 2021
Merged

sinks add redis plugin #895

merged 2 commits into from Aug 11, 2021

Conversation

feng-crazy
Copy link
Contributor

sinks add redis plugin

@jinfahua jinfahua requested a review from ngjaying July 15, 2021 07:43
ngjaying
ngjaying requested changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@ngjaying ngjaying left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Appreciate your contribution. As a request from LF Edge, please sign off your commits. Click "detail" in the DCO check for how to do that. Also, could you please add a doc to docs/plugins/sinks for Chinese and/or English.

etc/sinks/redis.json Outdated Show resolved Hide resolved
extensions/sinks/redis/redis.go Show resolved Hide resolved
extensions/sinks/redis/redis.go Outdated Show resolved Hide resolved
extensions/sinks/redis/redis.go Outdated Show resolved Hide resolved
@ngjaying
Copy link
Collaborator

DCO fails with invalid email. You'll need to setup the email

$ git config --global user.email name@example.com

@ngjaying ngjaying added area/extension kind/feature New feature or request labels Aug 3, 2021
@ngjaying ngjaying added this to the 1.3.0 milestone Aug 3, 2021
@ngjaying
Copy link
Collaborator

ngjaying commented Aug 6, 2021

@feng-crazy We would like to add this to 1.3.0 release. Are you able to sign off before next Wednesday? Thanks.

feng-crazy and others added 2 commits August 11, 2021 15:47
@feng-crazy @ngjaying
feat(extension): sinks add redis plugin
e9cd4f2 
Signed-off-by: hedengfeng <894220128@qq.com>
@ngjaying
feat(extension): add redis sink to build
1fc2e79 
Signed-off-by: Jiyong Huang <huangjy@emqx.io>
@ngjaying
Copy link
Collaborator

@feng-crazy Thank you again for contribute this plugin. I squash your commits into one and format the user/email to pass the DCO. I force push the updates to the master branch of your fork. Sorry for any inconvenience.

@ngjaying ngjaying merged commit adadd52 into lf-edge:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngjaying ngjaying ngjaying approved these changes

Assignees
No one assigned
Labels
area/extension kind/feature New feature or request
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feng-crazy @ngjaying