Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Hailo 8 FW #3719

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Jan 26, 2024

No description provided.

@rucoder rucoder requested a review from rene as a code owner January 26, 2024 12:30
@rucoder rucoder requested review from eriknordmark and removed request for rene January 26, 2024 12:30
@github-actions github-actions bot requested a review from rene January 26, 2024 12:31
@rucoder rucoder requested review from rene and removed request for rene January 26, 2024 12:34
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.60%. Comparing base (2c5fb18) to head (f39bd53).
Report is 4 commits behind head on master.

Current head f39bd53 differs from pull request most recent head 2214416

Please upload reports for the commit 2214416 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3719      +/-   ##
==========================================
+ Coverage   17.51%   19.60%   +2.08%     
==========================================
  Files           3      232     +229     
  Lines         805    50770   +49965     
==========================================
+ Hits          141     9953    +9812     
- Misses        629    40094   +39465     
- Partials       35      723     +688     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -61,6 +61,12 @@ ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C0.hcd .
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM43430B0.hcd .
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C5.hcd .

# Hailo GPU firmware
# we've got a written permission to include this firmware into EVE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think we must take this with precaution. Although it's a firmware blob, so we are not talking about source code to be included on EVE, this written permission should be compatible with Apache 2.0, which means that it should not forbid us in anyway from any of the permissions guaranteed by our license: rights to use the software as it is, rights to change it (EVE), rights to share it... since it's a firmware blob, perhaps the most important is the right to share it as we wish (within EVE, of course)... I think it's important to include a license file here, we do have proprietary firmware in this package (i.MX, NVIDIA), but they have specific (proprietary) licenses that allows to share, pack with EVE, etc, i.e., which doesn't break the terms of our license...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene yes, sure. I've submitted this PR as a placeholder so I do not loose the code. still waiting for confirmation and proper license file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be feasible to download it during VM deployment.

Copy link
Contributor Author

@rucoder rucoder Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be feasible to download it during VM deployment.

not really, the end user must accept EULA but we managed to get approval from Hailo

@rucoder rucoder changed the title [DO NOT MERGE YET ] Integrate Hailo 8 FW Integrate Hailo 8 FW Jun 12, 2024
@rucoder rucoder requested a review from aw-was-here June 12, 2024 08:22
@github-actions github-actions bot requested a review from rene June 12, 2024 08:42
@rucoder rucoder requested a review from temerkhanov June 12, 2024 11:54
pkg/fw/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Copy link
Collaborator

@rene rene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit f24f3b5 into lf-edge:master Jun 12, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants