pkg/fscrypt: support builds for other ARCHs #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pillar, which is crossbuildable, depends on fscrypt. Without this cludge any attempt to build pillar for any ARCH other than amd64 raises the following absolutely implicit and opague error: Error: error building "lfedge/eve-pillar:f6cd4c5f47f4900781840ea5b861ddecca52c35d": error building for arch arm64: failed to solve: no match for platform in manifest: not found Which can mean anything. By trials and errors build problems with the fscrypt were determined. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3824 +/- ##
=======================================
Coverage 17.51% 17.51%
=======================================
Files 3 3
Lines 805 805
=======================================
Hits 141 141
Misses 629 629
Partials 35 35 ☔ View full report in Codecov by Sentry. |
eriknordmark
approved these changes
Mar 19, 2024
|
Unfortunately nothing indicates that pillar build fails because of fscrypt, which misses another arch build. I assume once dnsmasq or gpt-tools updated (new sha generated) - similar failure will happen on attempt to rebuild pillar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pillar, which is crossbuildable, depends on fscrypt. Without this cludge any attempt to build pillar for any ARCH other than amd64 raises the following absolutely implicit and opague error:
Which can mean anything. By trials and errors build problems with the fscrypt were determined.
cc: @deitch