-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include bpftrace by src part2 pkg bpftrace #3916
base: master
Are you sure you want to change the base?
Include bpftrace by src part2 pkg bpftrace #3916
Conversation
933dcf5
to
34defc2
Compare
34defc2
to
96d5986
Compare
pkg/bpftrace/Dockerfile
Outdated
RUN eve-alpine-deploy.sh | ||
|
||
RUN mkdir -p /usr/src | ||
ADD https://github.com/christoph-zededa/bpftrace/archive/refs/heads/eve.zip /usr/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a standard place to pull this from an repo upstream so that we can get a version string etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to the official repository and put my code as patches on top.
96d5986
to
85df835
Compare
7b7d5fb
to
8f41b93
Compare
1e2fb26
to
852680e
Compare
It would be good to have a security review with @shjala once he is back - to make sure we are aware of how to handle arbitrary ebpf code or whether we will instead somehow provide approved and signed ebpf programs. |
852680e
to
ba62d9a
Compare
@eriknordmark we had a discussion with Christoph, the main concerns are two helper functions 1) The proposed changes will unblock the PR for now... |
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
ba62d9a
to
74fec93
Compare
Moved to draft state until I have done the security changes for the kernel. |
has to be changed once #3915 is merged