Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab manual updates #14

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Lab manual updates #14

merged 8 commits into from
Aug 24, 2023

Conversation

perry0513
Copy link
Collaborator

@perry0513 perry0513 commented Aug 23, 2023

I've added some updates about the instruction and specific notes to VM users. Any suggestions are welcomed.

I'm also wondering whether it makes sense to specify file names for exercises that require students to create new programs. That way it will be easier to refer to the programs later on and also easier for instructors to check those files if they have the same names. What do you all think? (For example, in 3.5 and 5.3 the manual asks the students to create programs but without a filename)

Fixes #18.

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful, thanks!! I've made some suggestions. I like your suggestion of specifying the filenames to use for solutions. I'll make a pass and do that.

src/Peripherals.md Outdated Show resolved Hide resolved
src/Tools.md Outdated Show resolved Hide resolved
src/Tools.md Show resolved Hide resolved
src/Tools.md Show resolved Hide resolved
Copy link
Collaborator Author

@perry0513 perry0513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments. Please let me know what you think!

src/Tools.md Outdated Show resolved Hide resolved
src/Tools.md Show resolved Hide resolved
src/Peripherals.md Outdated Show resolved Hide resolved
src/Tools.md Outdated Show resolved Hide resolved
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @perry0513!

@lhstrh lhstrh dismissed edwardalee’s stale review August 24, 2023 06:03

Requested changes have been addressed.

@lhstrh lhstrh merged commit 06bdb76 into lf-lang:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference to RP2040 datasheet
4 participants