Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to allow building this project in Eclipse #14

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Mar 28, 2023

Works around #13.

@lhstrh lhstrh changed the title Update lingua-franca submodule Workaround to allow building this project in Eclipse Mar 28, 2023
@lhstrh lhstrh requested review from edwardalee and a-sr March 28, 2023 00:34
@lhstrh
Copy link
Member Author

lhstrh commented Mar 28, 2023

A bunch of Maven warnings/errors popped up in CI:

Warning:  org.eclipse.jdt:org.eclipse.jdt.core/maven-metadata.xmlfailed to transfer from http://0.0.0.0/ during a previous attempt. This failure was cached in the local repository and resolution will not be reattempted until the update interval of maven-default-http-blocker has elapsed or updates are forced. Original error: Could not transfer metadata org.eclipse.jdt:org.eclipse.jdt.core/maven-metadata.xml from/to maven-default-http-blocker (http://0.0.0.0/): transfer failed for http://0.0.0.0/org/eclipse/jdt/org.eclipse.jdt.core/maven-metadata.xml

Not sure what's up with that.

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this bind Epoch to a particular commit? Will this require manually updating Epoch every time lingua-franca master changes?

Note that the nightly build no longer creates a nightly build of Epoch, contrary to what this web page states:

https://www.lf-lang.org/docs/handbook/epoch-ide?target=c

@edwardalee
Copy link
Contributor

I just pulled this branch and tried mvn clean package and it still fails.
So the current situation is that we have no way to create or download an Epoch that is compatible with the latest checking to master, which redesigns the syntax for overriding parameters.

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java (mwe2Launcher) on project org.lflang: Execution mwe2Launcher of goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java failed: Plugin org.codehaus.mojo:exec-maven-plugin:3.0.0 or one of its dependencies could not be resolved: Failed to collect dependencies at org.codehaus.mojo:exec-maven-plugin:jar:3.0.0 -> org.eclipse.emf:org.eclipse.emf.mwe2.launch:jar:2.13.0 -> org.eclipse.emf:org.eclipse.emf.mwe2.runtime:jar:[2.13.0]: No versions available for org.eclipse.emf:org.eclipse.emf.mwe2.runtime:jar:[2.13.0] within specified range -> [Help 1]

@lhstrh
Copy link
Member Author

lhstrh commented Mar 28, 2023

Will this bind Epoch to a particular commit? Will this require manually updating Epoch every time lingua-franca master changes?

That is already the case (and so it is for the VS Code extension). We don't need to update it every time, but if we do, we could automate this. This should be helpful for creating nightly releases for both of them.

Note that the nightly build no longer creates a nightly build of Epoch, contrary to what this web page states:

https://www.lf-lang.org/docs/handbook/epoch-ide?target=c

Right, this has to be fixed, but let's first get it to build...

@lhstrh
Copy link
Member Author

lhstrh commented Mar 28, 2023

Looks like @a-sr fixed the build with the new exclusion rule. There are some remaining test errors to address:

Failures: 
  TemplateCompilationTest.compileTemplate:148 Validation error! expected:<[]> but was:<[This syntax is deprecated in the C target, use an equal sign instead of parentheses for assignment. (run the formatter to fix this automatically)]>
  TemplateCompilationTest.compileTemplate:148 Validation error! expected:<[]> but was:<[This syntax is deprecated in the C target, use an equal sign instead of parentheses for assignment. (run the formatter to fix this automatically)]>
  TemplateCompilationTest.compileTemplate:148 Validation error! expected:<[]> but was:<[This syntax is deprecated in the C target, use an equal sign instead of parentheses for assignment. (run the formatter to fix this automatically)]>
  TemplateCompilationTest.compileTemplate:148 Validation error! expected:<[]> but was:<[This syntax is deprecated in the TypeScript target, use an equal sign instead of parentheses for assignment. (run the formatter to fix this automatically)]>

@a-sr
Copy link
Collaborator

a-sr commented Mar 28, 2023

I was able to fix the build errors. The warnings may be caused by a temporary downtime of the eclipse servers.
While the CI build works, the tests currently fail because the LF example files used in the project templates are tested and use now deprecated syntax ("This syntax is deprecated in the C target, use an equal sign instead of parentheses for assignment. (run the formatter to fix this automatically)") issuing an error marker. I will take a look at them asap.

@a-sr
Copy link
Collaborator

a-sr commented Mar 28, 2023

I just pulled this branch and tried mvn clean package and it still fails. So the current situation is that we have no way to create or download an Epoch that is compatible with the latest checking to master, which redesigns the syntax for overriding parameters.

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java (mwe2Launcher) on project org.lflang: Execution mwe2Launcher of goal org.codehaus.mojo:exec-maven-plugin:3.0.0:java failed: Plugin org.codehaus.mojo:exec-maven-plugin:3.0.0 or one of its dependencies could not be resolved: Failed to collect dependencies at org.codehaus.mojo:exec-maven-plugin:jar:3.0.0 -> org.eclipse.emf:org.eclipse.emf.mwe2.launch:jar:2.13.0 -> org.eclipse.emf:org.eclipse.emf.mwe2.runtime:jar:[2.13.0]: No versions available for org.eclipse.emf:org.eclipse.emf.mwe2.runtime:jar:[2.13.0] within specified range -> [Help 1]

I was not able to reproduce the error in a fresh clone of the repository and the CI build on GH is also working.
Sometimes maven caches bad dependencies. You could try running mvn -U package, sometimes this helps with such issues.

Copy link
Collaborator

@a-sr a-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhstrh Thanks for fixing the files

@edwardalee edwardalee merged commit c90dad9 into main Mar 30, 2023
@lhstrh lhstrh deleted the fix-eclipse-build branch September 2, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants