Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI unit tests #1467

Merged
merged 19 commits into from
Nov 21, 2022
Merged

Add CLI unit tests #1467

merged 19 commits into from
Nov 21, 2022

Conversation

oowekyala
Copy link
Collaborator

@oowekyala oowekyala commented Nov 10, 2022

I found a bug whereby wrong CLI options were reported as "no such file or directory", and found that there are no tests for this, so here they are.

Ref #1429

Also fix bug whereby wrong CLI args
caused "no such file or directory" error
instead of "unrecognized option".
Could also be reverted and postponed
to be done more completely. However,
LFCommand would need a solution to
get access to an Io instance.
Sine Io is currently written in Kotlin,
we would probably need to convert it
to Java, otherwise we would break the
eclipse build.
@oowekyala oowekyala mentioned this pull request Nov 11, 2022
@oowekyala oowekyala marked this pull request as ready for review November 15, 2022 14:53
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for taking care of the tests!

org.lflang.tests/src/org/lflang/tests/cli/LfcCliTest.java Outdated Show resolved Hide resolved
org.lflang/src/org/lflang/FileConfig.java Outdated Show resolved Hide resolved
@cmnrd cmnrd merged commit e6ce24e into master Nov 21, 2022
@cmnrd cmnrd deleted the clem.cli-tests branch November 21, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants