-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI unit tests #1467
Merged
Merged
Add CLI unit tests #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix bug whereby wrong CLI args caused "no such file or directory" error instead of "unrecognized option".
oowekyala
commented
Nov 10, 2022
Could also be reverted and postponed to be done more completely. However, LFCommand would need a solution to get access to an Io instance. Sine Io is currently written in Kotlin, we would probably need to convert it to Java, otherwise we would break the eclipse build.
Closed
oowekyala
force-pushed
the
clem.cli-tests
branch
from
November 14, 2022 10:24
d90db16
to
f1f4b8e
Compare
cmnrd
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thanks for taking care of the tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug whereby wrong CLI options were reported as "no such file or directory", and found that there are no tests for this, so here they are.
Ref #1429