Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for authenticated federation #1698

Merged
merged 23 commits into from Apr 27, 2023
Merged

Fix for authenticated federation #1698

merged 23 commits into from Apr 27, 2023

Conversation

Jakio815
Copy link
Collaborator

@Jakio815 Jakio815 commented Apr 14, 2023

This resolves #1666.

Please merge together with lf-lang/reactor-c#196.

@Jakio815 Jakio815 marked this pull request as draft April 14, 2023 08:12
@Jakio815 Jakio815 changed the title Test SimpleFederatedAuthenticatd CI test Draft: Fix SimpleFederatedAuthenticated.lf broken CI test Apr 14, 2023
@Jakio815
Copy link
Collaborator Author

@petervdonovan Hi Peter. I really don't understand what's the problem and asking you for some insights.

The problem is the CI test runner can't find openssl headers, when making federate binaries.

The problem is this part.

/Users/runner/work/lingua-franca/lingua-franca/test/C/fed-gen/SimpleFederatedAuthenticated/src-gen/fed1/core/federated/federate.c:65:10: fatal error: 'openssl/rand.h' file not found

and I see it's happening when the make command occurs. But I don't understand why it's not working, because the CMake's OpenSSL linking has worked above. Also, the RTI build also works which also needs openssl headers.

I really don't know why it's not working. I have a bunch of tries on my commits, so you may check it out if the CI test takes too long.

I hope for your help!

@petervdonovan
Copy link
Collaborator

It looks like you're doing basically the right things here, and I do not know off the top of my head what the issue is likely to be. However, here are some ideas:

  • where you write if (osName.contains("mac")) { in CMakeLists.txt, make sure that it isn't returning darwin, or something like that, instead of mac. You can add debug prints to the CMakeLists.txt if you need to in order to check that the branch is being executed.
  • You can also try to SSH into the GitHub Actions runner. This is surprisingly easy and is briefly mentioned here.

@Jakio815
Copy link
Collaborator Author

Wow. Never knew I could ssh into the runner. I'll try that! Thanks!

@Jakio815 Jakio815 marked this pull request as ready for review April 22, 2023 14:47
@Jakio815 Jakio815 changed the title Draft: Fix SimpleFederatedAuthenticated.lf broken CI test Fix SimpleFederatedAuthenticated.lf broken CI test Apr 22, 2023
@Jakio815
Copy link
Collaborator Author

@lhstrh It's finally ready. Thanks to @petervdonovan telling me the ssh trick!

@Jakio815 Jakio815 requested a review from lhstrh April 22, 2023 14:49
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this 👍

@lhstrh lhstrh changed the title Fix SimpleFederatedAuthenticated.lf broken CI test Auhenticated federation fixed Apr 27, 2023
@lhstrh lhstrh added the bugfix label Apr 27, 2023
@lhstrh lhstrh merged commit ea974a8 into master Apr 27, 2023
41 checks passed
@lhstrh lhstrh deleted the auth-fail-test branch April 27, 2023 00:44
@petervdonovan petervdonovan changed the title Auhenticated federation fixed Fix for authenticated federation Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticated federation is not working
3 participants