Delete unnecessary complexity from build-lf-cli
#1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not been able to get this script to detect changes in my file system. At first I thought this was a Gradle issue, but it is just a problem in the bash script.
If anyone wishes to make this mechanism work properly, then I will not stop them. However, Gradle is already supposed to detect when nothing needs to be rebuilt, so if we do it this way and something needs to be rebuilt, then we are just doing the same check twice, which is a waste of time. Furthermore, if nothing needed to be rebuilt, then we would not be running this script. Let us not make an incremental build system out of bash scripts.