Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ROS serialization #1755

Merged
merged 1 commit into from May 20, 2023
Merged

Fix for ROS serialization #1755

merged 1 commit into from May 20, 2023

Conversation

petervdonovan
Copy link
Collaborator

The problem was that the relevant #includes were behind an extern "C".

@petervdonovan
Fix ROS serialization.
34c8bcb 
The problem was that the relevant #includes were behind an extern "C".
@petervdonovan petervdonovan requested a review from lhstrh May 20, 2023 00:19
lhstrh
lhstrh approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual test failures are masked by the issue described in #1752, but if this fixes it locally for you, then let's merge it.

@petervdonovan
Copy link
Collaborator Author

Yes, it fixes it locally for me.

@petervdonovan
Copy link
Collaborator Author

The tests are failing because of the "prepublish" thing, but that is a separate issue, so I'll just merge.

@petervdonovan petervdonovan merged commit 6c415be into master May 20, 2023
40 of 41 checks passed
@petervdonovan petervdonovan deleted the fix-ros-serialization branch May 20, 2023 00:30
@petervdonovan petervdonovan changed the title Fix ROS serialization Fix for ROS serialization Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petervdonovan @lhstrh