Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New --check flag for lff #1822

Merged
merged 6 commits into from Jun 8, 2023
Merged

New --check flag for lff #1822

merged 6 commits into from Jun 8, 2023

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jun 7, 2023

This implements a --check option for lff. In this check mode, lff reports all files that it would reformat as errors and only returns with a zero exit code if it would not change any files.

@cmnrd cmnrd added the enhancement Enhancement of existing feature label Jun 7, 2023
@cmnrd cmnrd added this to the 0.5.0 milestone Jun 7, 2023
@cmnrd cmnrd requested review from lhstrh and patilatharva June 7, 2023 10:14
@cmnrd cmnrd changed the title lff chcek mode lff check mode Jun 7, 2023
@lhstrh lhstrh changed the title lff check mode --check flag for lff Jun 7, 2023
lhstrh
lhstrh approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Thanks for adding the tests also 🚀

@lhstrh lhstrh enabled auto-merge June 7, 2023 16:11
@lhstrh lhstrh removed the request for review from patilatharva June 7, 2023 16:12
@lhstrh lhstrh changed the title --check flag for lff New --check flag for lff Jun 7, 2023
@lhstrh lhstrh added this pull request to the merge queue Jun 7, 2023
Merged via the queue into master with commit 7fe78bb Jun 8, 2023
42 checks passed
@lhstrh lhstrh deleted the lff-chcek branch June 8, 2023 01:34
@lhstrh lhstrh mentioned this pull request Jun 8, 2023
Merged
2 tasks
@petervdonovan petervdonovan added feature New feature and removed enhancement Enhancement of existing feature labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmnrd @lhstrh @petervdonovan