Bugfix for when top-level multiport width in federation depends on parameter #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR uncovered #1957 by making some ports into multiports that were not previously multiports (because we went from no width spec to a width spec of |
|
I'm not sure what is going on with the TS federated tests, so I re-ran them. I will need to take another look before this can get merged. |
|
I think I fixed the problem with the failing TypeScript test as well as #1961. Let's see if the tests pass. |
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply computes the concrete numeric value of the parameter at compile time.
Closes #1942.
Closes #1957.
Closes #1961.
Instead of adding a test, this PR simply modifies an existing test. The disadvantage of this approach is that when one test is used to test many features, it may not be as useful as a minimal reproducible example. The advantage of this approach is that it does not significantly increase the time/cost of running all the tests, whereas adding a new test creates redundant work by executing code that is common to all the tests.