Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hostname for RTI in dockerized federation changed from "localhost" to "rti" #1993

Merged
merged 4 commits into from Sep 8, 2023

Conversation

byeonggiljun
Copy link
Collaborator

@byeonggiljun byeonggiljun commented Sep 7, 2023

Dockerized federation programs should use "rti" as the hostname of the RTI as default to get a proper IP address of the RTI.

@byeonggiljun byeonggiljun changed the title Use "rti" as the hostname of the RTI when it comes to a dockerized Use "rti" as the hostname of the RTI in a dockerized federation Sep 7, 2023
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for pushing this fix, @byeong-gil! Please remove the FIXME and mark as "ready for review." I think we can go ahead and merge this...

@byeonggiljun byeonggiljun marked this pull request as ready for review September 7, 2023 23:27
@lhstrh lhstrh changed the title Use "rti" as the hostname of the RTI in a dockerized federation Default hostname for RTI in dockerized federation changed from "localhost" to "rti" Sep 7, 2023
@lhstrh lhstrh added this pull request to the merge queue Sep 8, 2023
Merged via the queue into master with commit 6e6d0e9 Sep 8, 2023
41 checks passed
@lhstrh lhstrh deleted the docker-hostname branch September 8, 2023 10:13
@lhstrh lhstrh added the bugfix label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants