Better placement of line directives #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, close the verbatim blocks with line directives pointing back to the current file.
2 tasks
We received feedback that line directives are not helpful when the LF source code that the correspond to is not C code.
petervdonovan
force-pushed
the
line-directives
branch
from
429a6c3
to
9b56b62
Compare
2 tasks
In .ino files, do not reference current file in #line directives.
petervdonovan
force-pushed
the
line-directives
branch
from
8f74fb6
to
6d10a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this addresses the concerns raised by @KyotoMicrocomputer, except for the command-line flag that suppresses line directives. The flag can be added separately.