Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to test output to show progress #2137

Merged
merged 1 commit into from Dec 28, 2023
Merged

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Dec 20, 2023

This turns the progress bar into an explicit percentage and shows which test is currently run. This is useful for situations where a test gets stuck.

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhstrh lhstrh added this pull request to the merge queue Dec 20, 2023
@lhstrh lhstrh removed this pull request from the merge queue due to a manual request Dec 20, 2023
@edwardalee edwardalee added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 21, 2023
@edwardalee edwardalee added this pull request to the merge queue Dec 28, 2023
@lhstrh
Copy link
Member Author

lhstrh commented Dec 28, 2023

The PR history shows that this PR won't get through the merge queue because it fails. The failures are not in this PR but in master. We have to fix the failures first; adding this to the merge queue will just clog CI, to no avail...

@edwardalee edwardalee removed this pull request from the merge queue due to a manual request Dec 28, 2023
@edwardalee edwardalee merged commit 456afdf into master Dec 28, 2023
43 checks passed
@edwardalee edwardalee deleted the show-progress branch December 28, 2023 19:04
@edwardalee
Copy link
Collaborator

I merged it because we can't fix master without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants