Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE bug for instance in mode #2270

Merged
merged 5 commits into from
Apr 28, 2024
Merged

Fix NPE bug for instance in mode #2270

merged 5 commits into from
Apr 28, 2024

Conversation

edwardalee
Copy link
Collaborator

This PR fixes #2269.

@edwardalee edwardalee requested a review from lhstrh April 27, 2024 15:42
@edwardalee edwardalee mentioned this pull request Apr 27, 2024
Closed
lhstrh
lhstrh requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the wildcard imports, looks good to me!

core/src/main/java/org/lflang/graph/InstantiationGraph.java Outdated Show resolved Hide resolved
@lhstrh lhstrh self-requested a review April 28, 2024 05:26
@lhstrh lhstrh enabled auto-merge April 28, 2024 05:26
@lhstrh lhstrh added this pull request to the merge queue Apr 28, 2024
Merged via the queue into master with commit ca250f1 Apr 28, 2024
24 checks passed
@lhstrh lhstrh deleted the instance-in-mode branch April 28, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing a reactor with instance in a mode triggers a NPE
2 participants
@edwardalee @lhstrh