Fix problem with merging of reaction plans #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oowekyala
force-pushed
the
fix-buffer-problem
branch
from
0aaa212
to
273b119
Compare
Was being merged with the wrong key
oowekyala
force-pushed
the
fix-buffer-problem
branch
from
273b119
to
a419303
Compare
jhaye
approved these changes
Sep 6, 2022
oowekyala
force-pushed
the
fix-buffer-problem
branch
from
fb29aec
to
a9780b8
Compare
oowekyala
force-pushed
the
fix-buffer-problem
branch
from
a9780b8
to
fe8429f
Compare
Closed
This was referenced Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14. The problem was that reactions were being merged in the entry for the wrong level. One reaction was then executed twice on the same time step, at different levels.