Use of stable toolchain for lints in CI #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recall this was a problem in the past. Just remember to also change the Rust CI at the main Lingua Franca repo when the runtime version is bumped. |
|
I think the Rust version in the LF repo is also fetched with the same github action, and it uses stable Rust there: https://github.com/lf-lang/lingua-franca/blob/master/.github/workflows/rs-tests.yml#L18 So I don't think we need to update anything explicitly, as long as the runtime stays on Rust stable. Right? |
|
Yes, I think these were the problems I was thinking about. But everything seems to be working now. Forget what I said. |
lhstrh
approved these changes
Nov 1, 2022
lhstrh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the nightly toolchain causes failures in CI: https://github.com/lf-lang/reactor-rs/actions/runs/3345256641/jobs/5540551199
This is because clippy is reporting something that can only be fixed when using Rust 1.65 nightly, whereas we currently use 1.64 stable, so we can't fix these lints.
Somewhat related to #32