JSON serialization #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokeun
reviewed
May 8, 2022
src/core/federation.ts
Outdated
| public registerFederatePortAction<T extends Present>(federatePortID: number, federatePortAction: Action<Buffer>) { | ||
| Object.setPrototypeOf(federatePortAction, FederatePortAction.prototype); | ||
| public registerFederatePortAction<T extends Present>(federatePortID: number, federatePortAction: Action<T>) { | ||
| //Object.setPrototypeOf(federatePortAction, Action<T>.prototype); |
| let msg = Buffer.alloc(data.length + 21); | ||
| public sendRTITimedMessage<T extends Present>(data: T, destFederateID: number, destPortID: number, time: Buffer) { | ||
| const value = Buffer.from(JSON.stringify(data), "utf-8"); | ||
|
|
| @@ -1784,7 +1784,7 @@ export class App extends Reactor { | |||
| * @param destFederateID The federate ID that is the destination of this message. | |||
There was a problem hiding this comment.
Can you update the comment on @param data? It's not a Buffer anymore.
lhstrh
reviewed
May 10, 2022
lhstrh
approved these changes
May 10, 2022
goekberk
added a commit
to goekberk/reactor-ts
that referenced
this pull request
May 11, 2022
…ion"" This reverts commit e055dca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LF PR to be merged together with this PR: lf-lang/lingua-franca#1125