Skip to content

Commit

Permalink
Update message for missing dependencies.
Browse files Browse the repository at this point in the history
This is mostly relevant to packages managed by NVM, which seem to be
located in a special place.
  • Loading branch information
petervdonovan committed Jun 12, 2023
1 parent 2e5e842 commit 07cffb9
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/check_dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,14 @@ const checkDependency: UserFacingVersionCheckerMaker = (dependency: DependencyIn
(MessageDisplayHelper: MessageDisplayHelper) => async () => {
const checkerResult: versionChecker.VersionCheckResult = await dependency.checker();
if (checkerResult.isCorrect) return true;
const message: string = await (checkerResult.isCorrect === false ? (
const disclaimer = "If this dependency is already on your system, start VS Code from a terminal emulator so that VS Code sees the same value of your PATH that you see in your terminal."
const message: string = (await (checkerResult.isCorrect === false ? (
dependency.wrongVersionMessage?.(checkerResult)
?? dependency.message(checkerResult)
) : dependency.message(checkerResult));
) : dependency.message(checkerResult))) + "\n" + disclaimer;
const installCommand: InstallCommand = await dependency.installCommand?.(checkerResult);
if (!installCommand && !dependency.installLink) {
MessageDisplayHelper(message);
MessageDisplayHelper(message + disclaimer);
return false;
}
const buttonText: string = !installCommand ? 'View download page' : (
Expand Down

0 comments on commit 07cffb9

Please sign in to comment.