You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that most of the changes in the "known good" files come from tokenizing whitespace, which seems entirely harmless.
This is untrue. We should not tokenize whitespace, as was done in #111.
This is because although whitespace is not colored in VS code, if you use a theme such as Abyss or Monokai which uses underlines, the whitespace will be underlined, which is not good.
We can either match a fixed amount of whitespace (which is brittle; we should probably avoid that), use programmatic highlighting instead of declarative highlighting (see highlight.ts), or do some trick with conditionally nested groups of patterns. This third option is what we do in order to apply the correct target language highlighter according to the target declaration, and I think I prefer it.
The text was updated successfully, but these errors were encountered:
Probably the most time-efficient thing would be for me to just try option 3 and see if it works at all -- I'm not sure I understand option 3, either (which makes it hard for me to explain it). I can aim to do it by Saturday.
Recently I wrote:
This is untrue. We should not tokenize whitespace, as was done in #111.
This is because although whitespace is not colored in VS code, if you use a theme such as Abyss or Monokai which uses underlines, the whitespace will be underlined, which is not good.
We can either match a fixed amount of whitespace (which is brittle; we should probably avoid that), use programmatic highlighting instead of declarative highlighting (see
highlight.ts
), or do some trick with conditionally nested groups of patterns. This third option is what we do in order to apply the correct target language highlighter according to the target declaration, and I think I prefer it.The text was updated successfully, but these errors were encountered: