Compatibility with Linguist #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can help to use both our own rule and a C++ rule.
petervdonovan
approved these changes
May 16, 2023
There was a problem hiding this comment.
I think that most of the changes in the "known good" files come from tokenizing whitespace, which seems entirely harmless. I just pushed some slight changes to the way types are highlighted in C/C++ to make sure there were no significant regressions there. I think that we should merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an updated version of #104 that incorporates the new syntax highlight tests (and slightly alters the known-good outputs). The purpose of the changes is to eliminate constructs that linguist does not allow (such as unbounded look-aheads) from our TextMate syntax description. After this is merged, we should be able to create PR for linguist.