Proprietary extension support #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This coupling between extensions might not be what we want -- it might be preferable to librarify the version checking code -- but it is the easiest thing to do right now and it isn't obviously a terrible idea.
evanw/esbuild#253 Webpack is slow, but it seems to be full-featured.
Webpack was generating __dirname code that threw runtime errors :(
petervdonovan
force-pushed
the
proprietary-extension-support
branch
from
c4c919b
to
8e53e66
Compare
lhstrh
reviewed
May 22, 2024
lhstrh
reviewed
May 22, 2024
lhstrh
reviewed
May 22, 2024
petervdonovan
force-pushed
the
proprietary-extension-support
branch
from
cc8dbc5
to
9a9b328
Compare
petervdonovan
force-pushed
the
proprietary-extension-support
branch
from
8294f81
to
f533bc0
Compare
petervdonovan
force-pushed
the
proprietary-extension-support
branch
5 times, most recently
from
ad27bce
to
1afb95d
Compare
petervdonovan
force-pushed
the
proprietary-extension-support
branch
from
1afb95d
to
9757e16
Compare
petervdonovan
force-pushed
the
proprietary-extension-support
branch
from
0de8058
to
c8b303e
Compare
lhstrh
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM! Thank you so much for fixing this quickly, @petervdonovan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161.
The problem was that this repository got out of sync with
lingua-franca'smasterbranch.lingua-franca'smasterbranch incorporated changes from a "proprietary extension support" branch, but this companion branch had not been merged yet.It feels necessary to explain how this happened since this problem can be avoided in the future. Part of the problem is that I spent a too much time working in unmerged feature branches and even declared that a feature had been implemented (while pointing to the unmerged feature branch) before the branch had been merged. This is a questionable practice that arose partly due to a desire to take a shortcut and partly due to uncertainty about what we actually would want in
mainin the long term. However, it is also true that we probably could have avoided publishing broken releases if I had been available to work in the past month.