Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error! macro #84

Closed
3 tasks
lambda-fairy opened this issue Apr 22, 2017 · 1 comment
Closed
3 tasks

Remove error! macro #84

lambda-fairy opened this issue Apr 22, 2017 · 1 comment

Comments

@lambda-fairy
Copy link
Owner

lambda-fairy commented Apr 22, 2017

See https://github.com/lfairy/maud/blob/be88fc39d5d56370d3db020ef85f4f093ab45a60/maud_macros/src/parse.rs#L14-L19

This should really be a method on Parser instead.

Tasks:

  • Add a Parser::error() method with a similar signature to the error!() macro
  • Change all instances of error!(...) to return self.error(...)
  • Remove the error!() macro
@lambda-fairy lambda-fairy changed the title Remove error!( macro Remove error! macro Apr 22, 2017
@alisha17
Copy link

I am working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants