-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export all should export all zones #9
Comments
Yes, all zones should be exported. I don't have 20 zones to test this, so I'll need your help with the testing. Let's say you have 30 zones, you run the command and only 20 zones get exported and it finishes? I think maybe CloudFlare is limiting the export to 20 zones, I will check the API I'm calling and give you more info. |
yes i can help testing. we have around 400 domains in CF
yes.
List Zones default value is 20 per page. https://api.cloudflare.com/#zone-list-zones
maybe a loop through the "result_info" could easy solve it |
yes, that's one options, maybe another option is to not limit the result page if CF api supports it. will issue a fix by tomorrow; thank you for the time invested reporting this @hebbet |
any news on that? |
hello @hebbet, I'm very sorry for keeping you waiting on this issue this long -- totally forgot about it. I pushed a fix right now, I have no way to test it -- lemme know if it solves your problem. as you suggested I loop through the then we just keep extracting the data for every page with a new request |
i pulled the image and tried again: |
I created the new image locally to confirm the new code works as expected: http://share.vlct.io/0f9d28 Just need you to confirm it works for 400 domains now :) |
@hebbet -- does it work as expected? |
no :-(
|
Try again, I removed that faulty header. $ docker pull lfaoro/flares
$ docker run -it --rm -e CF_API_KEY="$CF_API_KEY" -e CF_API_EMAIL="$CF_API_EMAIL" lfaoro/flares --all |
we are getting closer, but with a new error:
|
Good! Progress :D I'm coding in the blind, I don't have a way to test pagination -- gotta imagine what's going on. No worries, will try again, we'll get this issue solved one way or another. |
@hebbet -- I've refactored the whole tool, now you should be able to handle as many domains as you want in one go. $ flares --all --export |
What would you like?
when runninng
docker run -it --rm -e CF_API_KEY="$CF_API_KEY" -e CF_API_EMAIL="$CF_API_EMAIL" lfaoro/flares --all
it should export all zones and not only 20Describe the solution you'd like
all zones are exported
Describe alternatives you've considered (if any)
Additional context (if you want)
The text was updated successfully, but these errors were encountered: