Update reviewing.md to reflect CNTI #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs lfn-cnti#77 Signed-off-by: Martin Matyas <martin.matyas@gmail.com>
martin-mat
force-pushed
the
reviewing_lfn_update
branch
from
90f2b43
to
644f147
Compare
martin-mat
changed the title
lixuna
reviewed
Mar 14, 2024
| 1. Verify that the list of files matches the [expected list](https://github.com/lfn-cnti/certification/blob/main/instructions.md#contents-of-the-pr). | ||
| 1. Note the vX.Y subdirectory that the PR is in, this is the version of CNTI Certification for which certified is being claimed, referenced as the "Certification Version" from hereon. | ||
| 1. Verify that the Certification Version is the current or previous version of CNTI Certification. | ||
| 1. Look at results log, cnf-testsuite-results-YYYY-MMDD-HHMMSS-NNN.yml. Verify that the major.minor component of the CNTI Certification matches the certification version being claimed. The patch version does not matter. | ||
| 1. Verify that the RESULTS SUMMARY section of results log "X of Y essential tests passed". There should be at least 10 essential tests passed. |
There was a problem hiding this comment.
FYI - this sentence "There should be at least 10 essential tests passed" will be updated in the next 1-2 weeks when the v2.0 certification list of tests is updated.
Co-authored-by: Lucina Stricko <lucina@vulk.coop>
Co-authored-by: Lucina Stricko <lucina@vulk.coop>
lixuna
added a commit
that referenced
this pull request
Apr 2, 2024
Merged
taylor
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Update reviewing.md Refs #90 * Update reviewing.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #77
Pre-submission checklist:
Please check each of these after submitting your pull request: