Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: load the libraries of the js and the css locally #186

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

t29mato
Copy link
Collaborator

@t29mato t29mato commented Aug 22, 2023

@t29mato
Copy link
Collaborator Author

t29mato commented Aug 22, 2023

I have checked the initial drawing on the page where I replaced the library and briefly checked the functionality. I have not checked the detailed functionality.

@t29mato t29mato force-pushed the refactor/load-js-libraries-locally branch from 3f49c54 to 8e3a103 Compare August 22, 2023 05:41
@lfoppiano
Copy link
Owner

I have checked the initial drawing on the page where I replaced the library and briefly checked the functionality. I have not checked the detailed functionality.

What do you mean? You did not test it?

@lfoppiano lfoppiano merged commit 3b7d267 into develop Aug 25, 2023
2 checks passed
@lfoppiano lfoppiano deleted the refactor/load-js-libraries-locally branch August 25, 2023 03:01
@lfoppiano
Copy link
Owner

Tested by disabling the proxy and works!

@t29mato
Copy link
Collaborator Author

t29mato commented Aug 25, 2023

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants