-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lfortran.wasm and lfortran.js of different commits #24
Support lfortran.wasm and lfortran.js of different commits #24
Conversation
Also add view commit button
And rearrange imports at few places
636a014
to
a14d78f
Compare
At the moment, I am unsure if the changes in this The exact error is: Access to fetch at 'https://ubaidshaikh.me/wasm_builds/commit1/lfortran.wasm' from origin 'http://localhost:8000' has been
blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response
serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled. I am still hoping that the changes in this |
I think the wasm file must be present in the same gh-pages branch as the rest of the site, and consequently available from dev.lfortran.org. I would not load it from elsewhere. See https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS for more information. |
To move forward, why not first implement just the latest wasm binary, copy it to gh-pages etc. Let's get it done, merged, etc. After that, we can investigate how to support more versions. |
I just setup a demo of this |
Got it.
Got it. I am marking this |
The demo looks very nice. |
It seems
The changes worked initially but later stopped working, because, I guess later I was not using the right domain (I was using |
It seems that CORS requires some setup and support, and even thought github might now support it, I think it is more robust if we can figure out a way for it to work from the same domain. |
Got it. I am closing this for the moment. |
This
PR
adds support of usinglfortran.wasm
andlfortran.js
of differentmerge
commits oflfortran
master
.