You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now ASR verify is not tested at all. A well functioning AST->ASR pass as well as correct ASR->ASR passes will never trigger any ASR verify errors. However, we still need to ensure that ASR verify works correctly.
I think we can't test this with the frontend langauge code (Fortran). Rather, we must construct incorrect ASR directly and run ASR verify pass on it and ensure it fails.
One approach is to add C++ tests (executed via ctest) that construct ASR (either directly or via our builder), and check that ASR fails. Even more thorough test would be to check that it fails with the correct error message.
We can add some initial tests for the most important checks (regarding symbol table mostly). However we do not want to add too many, since it will increase our maintenance burden, as every time we change ASR we then have to manually change all these tests. I think we should do that after all big refactorings are done, so after beta, possibly closer to alpha.
The text was updated successfully, but these errors were encountered:
Right now ASR verify is not tested at all. A well functioning AST->ASR pass as well as correct ASR->ASR passes will never trigger any ASR verify errors. However, we still need to ensure that ASR verify works correctly.
I think we can't test this with the frontend langauge code (Fortran). Rather, we must construct incorrect ASR directly and run ASR verify pass on it and ensure it fails.
One approach is to add C++ tests (executed via ctest) that construct ASR (either directly or via our builder), and check that ASR fails. Even more thorough test would be to check that it fails with the correct error message.
We can add some initial tests for the most important checks (regarding symbol table mostly). However we do not want to add too many, since it will increase our maintenance burden, as every time we change ASR we then have to manually change all these tests. I think we should do that after all big refactorings are done, so after beta, possibly closer to alpha.
The text was updated successfully, but these errors were encountered: