[asr->fortran] implement visit_{FileOpen, FileClose, FileRead}

[khushi-411]

TODO

• enable remaining valid tests

[Thirumalai-Shaktivel]

It looks good so far!
If you feel you have finished the PR, please mark it as "Ready for Review".

[khushi-411]

Addressed all your reviews! Thanks, @Thirumalai-Shaktivel!

If you feel you have finished the PR, please mark it as "Ready for Review".

I think we can also enable some other tests too. For example: file_04.f90, these tests pass along with the NOFAST flag but not without it. This is the generated code for it:

generated code

program load_model_program
implicit none
integer(4) :: int_data1
integer(4) :: int_data2
real(4) :: real_data1
real(4) :: real_data2
integer(4), save :: u = 11
open(u, file="file_04_data.dat", form="unformatted")
read(u, *) int_data1, real_data1, int_data2, real_data2
print *, "Data: ", int_data1, real_data1, int_data2, real_data2
if (int_data1 /= 345239) then
    error stop
end if
if (abs(real_data1 - 52.910000) > 0.000001) then
    error stop
end if
if (int_data2 /= (-345239)) then
    error stop
end if
if (abs(real_data2 - (-52.910000)) > 0.000001) then
    error stop
end if
end program load_model_program

test code

program load_model_program
    implicit none

    integer :: int_data1, int_data2
    real :: real_data1, real_data2
    integer :: u = 11

    open(u, file="file_04_data.dat", form="unformatted", access="stream")
    read(u) int_data1, real_data1, int_data2, real_data2

    print *, "Data: ", int_data1, real_data1, int_data2, real_data2
    if (int_data1 /= 345239) error stop
    if (abs(real_data1 - (52.91)) > 1e-6) error stop
    if (int_data2 /= -345239) error stop
    if (abs(real_data2 - (-52.91)) > 1e-6) error stop
end program

What do you think?

[Thirumalai-Shaktivel]

LGTM, Thank you!

[Thirumalai-Shaktivel]

Thank you!

[Thirumalai-Shaktivel]

@Shaikh-Ubaid, can you review and merge this PR?

[Shaikh-Ubaid]

I shared a minor comment. This looks good to me! Very valuable contributions! Thanks for this!

[khushi-411]

Thanks for all your helpful reviews in the PR, @Thirumalai-Shaktivel & @Shaikh-Ubaid!

Have addressed all of your reviews!