Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selected_int_kind intrinsic #2736

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Fix selected_int_kind intrinsic #2736

merged 4 commits into from
Oct 27, 2023

Conversation

Pranavchiku
Copy link
Contributor

Fixes #2551

certik
certik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise I think this looks great, thanks!

integration_tests/selected_int_kind_01.f90 Show resolved Hide resolved
certik
certik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now, thanks!

Thirumalai-Shaktivel
Thirumalai-Shaktivel approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Thirumalai-Shaktivel Thirumalai-Shaktivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Pranavchiku Pranavchiku marked this pull request as ready for review October 27, 2023 07:39
@Pranavchiku Pranavchiku merged commit a58e7b5 into lfortran:main Oct 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

@Thirumalai-Shaktivel Thirumalai-Shaktivel Thirumalai-Shaktivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divergence in the output of selected_int_kind() for LFortran and GFortran
3 participants
@Pranavchiku @certik @Thirumalai-Shaktivel