Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor replace_symbol used in require statements #2745

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Refactor replace_symbol used in require statements #2745

merged 1 commit into from
Oct 27, 2023

Conversation

ansharlubis
Copy link
Contributor

I reverted the AST changes I made in #2721 and kept the replace_symbol refactor.

@ansharlubis ansharlubis added the generics Fortran 202Y Generics label Oct 27, 2023
@ansharlubis ansharlubis marked this pull request as ready for review October 27, 2023 18:10
certik
certik approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, thanks!

@certik certik enabled auto-merge October 27, 2023 18:31
@certik certik merged commit 532e6a9 into lfortran:main Oct 27, 2023
20 checks passed
@ansharlubis ansharlubis deleted the refactor-replace-symbol branch December 12, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
generics Fortran 202Y Generics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansharlubis @certik