Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra supports for --dump-all-passes-fortran #2749

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

Shaikh-Ubaid
Copy link
Member

@Shaikh-Ubaid Shaikh-Ubaid commented Oct 28, 2023

towards #2744.

Now it can only be used as lfortran main.f90 --dump-all-passes-fortran which is the same as how --dump-all-passes used to work previously before PR #2733 was merged.

Now it can only be used as lfortran main.f90 --dump-all-passes-fortran
@Shaikh-Ubaid
Copy link
Member Author

As described here #2733 (comment), we mentioned that we can use the ASR dumping as lfortran examples/expr2.f90 --show-asr --tree --dump-all-passes, but with this PR #2749, we have the following changes:

  • The --show-asr is not required or should not be used while dumping the ASR passes output. This is the same working as we used to have for --dump-all-passes before Support dumping ASR pass outputs in Json, Tree and Visualization forms  #2733 was merged.
  • Similar to --show-asr, --show-fortran should not be used while dumping the ASR passes output. One can simply use lfortran examples/expr2.f90 --dump-all-passes or lfortran examples/expr2.f90 --dump-all-passes --json/tree.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine.

@Shaikh-Ubaid Shaikh-Ubaid merged commit 647dbb7 into lfortran:main Oct 28, 2023
20 checks passed
@Shaikh-Ubaid Shaikh-Ubaid deleted the dump_all_passes_fortran branch October 28, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants