Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Bump SciPy to latest commit #2750

Merged
merged 1 commit into from
Oct 28, 2023
Merged

CI: Bump SciPy to latest commit #2750

merged 1 commit into from
Oct 28, 2023

Conversation

Pranavchiku
Copy link
Contributor

@Pranavchiku Pranavchiku commented Oct 28, 2023 •
edited

@Pranavchiku Pranavchiku added the SciPy issues related to enable LFortran to compile the entire FORTRAN codebase in SciPy label Oct 28, 2023
HarshitaKalani
HarshitaKalani requested changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@HarshitaKalani HarshitaKalani left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than picking these commits: certik/scipy@c3bbc83 and certik/scipy@93b4a9f, it'll be better to go with: certik/scipy@63b55b6

Ref: certik/scipy@e87a987#r131131449
We're actually keeping specfun_lib with the above commits.

@Pranavchiku
Copy link
Contributor Author

I preferred to keep each package independent, this makes it easy to pick any package if we need to test it.

@Pranavchiku
Copy link
Contributor Author

Rather than picking these commits: certik/scipy@c3bbc83 and certik/scipy@93b4a9f, it'll be better to go with: certik/scipy@63b55b6

Yes, I changed to certik/scipy@63b55b6

@Pranavchiku
Copy link
Contributor Author

I pushed the changes, @HarshitaKalani please check at https://github.com/certik/scipy/commits/merge_special_minpack_fitpack_02.

@HarshitaKalani
Copy link
Contributor

LGTM!

@Pranavchiku Pranavchiku marked this pull request as ready for review October 28, 2023 09:00
@Pranavchiku Pranavchiku merged commit 2c37cde into lfortran:main Oct 28, 2023
20 checks passed
@certik
Copy link
Contributor

certik commented Oct 28, 2023

Is this using the latest SciPy master?

@Pranavchiku
Copy link
Contributor Author

Pranavchiku commented Oct 28, 2023 •
edited

Yes, along with required commits ( for CMake and meson build ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshitaKalani HarshitaKalani HarshitaKalani approved these changes

Assignees
No one assigned
Labels
SciPy issues related to enable LFortran to compile the entire FORTRAN codebase in SciPy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pranavchiku @HarshitaKalani @certik