Bug: Fix the unit_file_bin not being initialized
#2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see if it fixes the failure. |
certik
reviewed
Nov 2, 2023
| @@ -1887,6 +1887,7 @@ void store_unit_file(int32_t unit_num, FILE* filep, bool unit_file_bin) { | |||
| } | |||
|
|
|||
| FILE* get_file_pointer_from_unit(int32_t unit_num, bool *unit_file_bin) { | |||
| unit_file_bin = false; | |||
There was a problem hiding this comment.
Should this be:
Suggested change
| unit_file_bin = false; | |
| *unit_file_bin = false; |
Thirumalai-Shaktivel
force-pushed
the
bug_07
branch
from
0d52f17
to
a485733
Compare
certik
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
I don't know if this is the right fix, we really need to start documenting what these functions are supposed to do. But it seems the API for this function is to return if the unit is a binary unit, in which case it was a bug that it returned a random value. So let's merge it and see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2776